diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-26 05:44:14 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-29 17:17:14 +0200 |
| commit | 541d2192cf0325f6b085a33828b40a0e5b23b76a (patch) | |
| tree | e6d6fbebb02b1a615af6aaf4ca85431bf6bf19d8 /lib/url.js | |
| parent | 29cddb40b238daf1dfad0cc42e0d3bd5068dff03 (diff) | |
| download | android-node-v8-541d2192cf0325f6b085a33828b40a0e5b23b76a.tar.gz android-node-v8-541d2192cf0325f6b085a33828b40a0e5b23b76a.tar.bz2 android-node-v8-541d2192cf0325f6b085a33828b40a0e5b23b76a.zip | |
test: fix a TODO and remove obsolete TODOs
This removes outdated TODOs and adds a test for invalid input in
`fs.copyFile` and solves a TODO by doing so.
PR-URL: https://github.com/nodejs/node/pull/20319
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/url.js')
| -rw-r--r-- | lib/url.js | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/lib/url.js b/lib/url.js index ac9879a650..e4326e80b5 100644 --- a/lib/url.js +++ b/lib/url.js @@ -281,9 +281,6 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) { // http://a@b@c/ => user:a@b host:c // http://a@b?@c => user:a host:b path:/?@c - // v0.12 TODO(isaacs): This is not quite how Chrome does things. - // Review our test case against browsers more comprehensively. - var hostEnd = -1; var atSign = -1; var nonHost = -1; |