diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-01-17 22:55:23 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-01-19 13:01:47 +0100 |
| commit | ea7400c1bd61672090a2ca7e72512a8fa16ad79d (patch) | |
| tree | b9c72e387e875d9dfd9b1da5f8018530c5771e45 /lib/tty.js | |
| parent | fe94394b99a39a4ed2c0589f825b6e4958fed629 (diff) | |
| download | android-node-v8-ea7400c1bd61672090a2ca7e72512a8fa16ad79d.tar.gz android-node-v8-ea7400c1bd61672090a2ca7e72512a8fa16ad79d.tar.bz2 android-node-v8-ea7400c1bd61672090a2ca7e72512a8fa16ad79d.zip | |
tty: fix console printing on Windows
This broke writing non-ASCII data to the console on Windows because
the result would be codepage-dependent.
This partially reverts 8b751f7eb7b05a0b27f52e2288a636fdd78e9ecb.
Fixes: https://github.com/nodejs/node/issues/18189
Refs: https://github.com/nodejs/node/pull/18019
PR-URL: https://github.com/nodejs/node/pull/18214
Fixes: https://github.com/nodejs/node/issues/18189
Refs: https://github.com/nodejs/node/pull/18019
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'lib/tty.js')
| -rw-r--r-- | lib/tty.js | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/lib/tty.js b/lib/tty.js index 28f2a41184..2a62fcb859 100644 --- a/lib/tty.js +++ b/lib/tty.js @@ -24,7 +24,6 @@ const util = require('util'); const net = require('net'); const { TTY, isTTY } = process.binding('tty_wrap'); -const { makeSyncWrite } = require('internal/net'); const { inherits } = util; const errnoException = util._errnoException; const errors = require('internal/errors'); @@ -92,8 +91,6 @@ function WriteStream(fd) { // even though it was originally intended to change in v1.0.2 (Libuv 1.2.1). // Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671 this._handle.setBlocking(true); - this._writev = null; - this._write = makeSyncWrite(fd); var winSize = new Array(2); var err = this._handle.getWindowSize(winSize); |