diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-11-30 17:55:48 +0100 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-12-05 16:53:58 +0100 |
commit | dcc82b37b631d636e0fefc8272c357ec4a7d6df2 (patch) | |
tree | 0a036ccfa7448c8d50628831084e9863a14a0766 /lib/perf_hooks.js | |
parent | 6ccc80c82a7e21bc9315d6fdccea62ce8e2712a7 (diff) | |
download | android-node-v8-dcc82b37b631d636e0fefc8272c357ec4a7d6df2.tar.gz android-node-v8-dcc82b37b631d636e0fefc8272c357ec4a7d6df2.tar.bz2 android-node-v8-dcc82b37b631d636e0fefc8272c357ec4a7d6df2.zip |
lib: remove `inherits()` usage
This switches all `util.inherits()` calls to use
`Object.setPrototypeOf()` instead. In fact, `util.inherits()` is
mainly a small wrapper around exactly this function while adding
the `_super` property on the object as well.
Refs: #24395
PR-URL: https://github.com/nodejs/node/pull/24755
Refs: https://github.com/nodejs/node/issues/24395
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'lib/perf_hooks.js')
-rw-r--r-- | lib/perf_hooks.js | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/lib/perf_hooks.js b/lib/perf_hooks.js index 1086c4b519..b84498055f 100644 --- a/lib/perf_hooks.js +++ b/lib/perf_hooks.js @@ -33,7 +33,6 @@ const { const { AsyncResource } = require('async_hooks'); const L = require('internal/linkedlist'); const kInspect = require('internal/util').customInspectSymbol; -const { inherits } = require('util'); const kCallback = Symbol('callback'); const kTypes = Symbol('types'); @@ -208,10 +207,8 @@ class PerformanceNodeTiming { }; } } -// Use this instead of Extends because we want PerformanceEntry in the -// prototype chain but we do not want to use the PerformanceEntry -// constructor for this. -inherits(PerformanceNodeTiming, PerformanceEntry); +Object.setPrototypeOf( + PerformanceNodeTiming.prototype, PerformanceEntry.prototype); const nodeTiming = new PerformanceNodeTiming(); |