diff options
| author | cjihrig <cjihrig@gmail.com> | 2018-06-20 17:27:09 -0400 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2018-06-22 10:19:20 -0400 |
| commit | d9e95d8982ee5b409b36f09c77feccbb1040095c (patch) | |
| tree | 00bf6a43093e9f37385244392135db228ad896cc /lib/net.js | |
| parent | 7ec6951034658b63f908977caeb83112d77cdf3b (diff) | |
| download | android-node-v8-d9e95d8982ee5b409b36f09c77feccbb1040095c.tar.gz android-node-v8-d9e95d8982ee5b409b36f09c77feccbb1040095c.tar.bz2 android-node-v8-d9e95d8982ee5b409b36f09c77feccbb1040095c.zip | |
net: validate fds passed to Socket constructor
This commit validates the file descriptor passed to the TTY
wrap's guessHandleType() function. Prior to this commit, a bad
file descriptor would trigger an abort in the binding layer.
PR-URL: https://github.com/nodejs/node/pull/21429
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'lib/net.js')
| -rw-r--r-- | lib/net.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/net.js b/lib/net.js index 0f80b41897..2f341f53a1 100644 --- a/lib/net.js +++ b/lib/net.js @@ -75,7 +75,7 @@ const { ERR_SOCKET_BAD_PORT, ERR_SOCKET_CLOSED } = errors.codes; - +const { validateInt32 } = require('internal/validators'); const kLastWriteQueueSize = Symbol('lastWriteQueueSize'); // Lazy loaded to improve startup performance. @@ -93,6 +93,7 @@ const { function noop() {} function createHandle(fd, is_server) { + validateInt32(fd, 'fd', 0); const type = TTYWrap.guessHandleType(fd); if (type === 'PIPE') { return new Pipe( |