net: honor default values in Socket constructor

Specifically `readable` and `writable` that default to `false`.

PR-URL: https://github.com/nodejs/node/pull/19971
Fixes: https://github.com/libuv/libuv/issues/1794
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

1 files changed, 5 insertions, 6 deletions

diff --git a/lib/net.js b/lib/net.js
index c367712686..6c47561911 100644
--- a/lib/net.js
+++ b/lib/net.js
@@ -244,6 +244,8 @@ function Socket(options) {
   else
     options = util._extend({}, options);
 
+  options.readable = options.readable || false;
+  options.writable = options.writable || false;
   const allowHalfOpen = options.allowHalfOpen;
 
   // Prevent the "no-half-open enforcer" from being inherited from `Duplex`.
@@ -283,9 +285,6 @@ function Socket(options) {
         value: 0, writable: true
       });
     }
-  } else {
-    // these will be set once there is a connection
-    this.readable = this.writable = false;
   }
 
   // shut down the socket when we're finished with it.
@@ -1537,10 +1536,10 @@ function onconnection(err, clientHandle) {
   var socket = new Socket({
     handle: clientHandle,
     allowHalfOpen: self.allowHalfOpen,
-    pauseOnCreate: self.pauseOnConnect
+    pauseOnCreate: self.pauseOnConnect,
+    readable: true,
+    writable: true
   });
-  socket.readable = socket.writable = true;
-
 
   self._connections++;
   socket.server = self;