diff options
author | cjihrig <cjihrig@gmail.com> | 2018-12-30 19:47:47 -0500 |
---|---|---|
committer | cjihrig <cjihrig@gmail.com> | 2019-01-01 19:36:34 -0500 |
commit | a779ee4fad71b22a35ff4fd8176e36f98ac2e684 (patch) | |
tree | 90b37f2d8f6951e8a0b939497cf6f97c476b88ff /lib/internal | |
parent | d32f769d75dc31773ad34b5c28ddefd2dbd84a57 (diff) | |
download | android-node-v8-a779ee4fad71b22a35ff4fd8176e36f98ac2e684.tar.gz android-node-v8-a779ee4fad71b22a35ff4fd8176e36f98ac2e684.tar.bz2 android-node-v8-a779ee4fad71b22a35ff4fd8176e36f98ac2e684.zip |
coverage: pass cwd to path.resolve() in setup
During coverage setup, path.resolve() is called.
path.resolve() can potentially call process.cwd(), which
hasn't been bootstrapped yet. This commit passes the
current working directory directly so that path.resolve()
doesn't attempt to compute it.
PR-URL: https://github.com/nodejs/node/pull/25289
Fixes: https://github.com/nodejs/node/issues/25287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/internal')
-rw-r--r-- | lib/internal/process/coverage.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/internal/process/coverage.js b/lib/internal/process/coverage.js index c84181db93..ef37deba8a 100644 --- a/lib/internal/process/coverage.js +++ b/lib/internal/process/coverage.js @@ -76,9 +76,10 @@ function setup() { })); try { + const { cwd } = internalBinding('process_methods'); const { resolve } = require('path'); coverageDirectory = process.env.NODE_V8_COVERAGE = - resolve(process.env.NODE_V8_COVERAGE); + resolve(cwd(), process.env.NODE_V8_COVERAGE); } catch (err) { process._rawDebug(err.toString()); } |