lib: use destructuring for some constants

This change is to unify the declaration for constants into using
destructuring on the top-level-module scope, reducing some redundant
code.

PR-URL: https://github.com/nodejs/node/pull/16063
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

8 files changed, 16 insertions, 19 deletions

diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js
index 28ab13cd54..70b13e0839 100644
--- a/lib/internal/child_process.js
+++ b/lib/internal/child_process.js
@@ -1,19 +1,19 @@
 'use strict';
 
 const errors = require('internal/errors');
-const StringDecoder = require('string_decoder').StringDecoder;
+const { StringDecoder } = require('string_decoder');
 const EventEmitter = require('events');
 const net = require('net');
 const dgram = require('dgram');
 const util = require('util');
 const assert = require('assert');
 
-const Process = process.binding('process_wrap').Process;
-const WriteWrap = process.binding('stream_wrap').WriteWrap;
-const Pipe = process.binding('pipe_wrap').Pipe;
-const TTY = process.binding('tty_wrap').TTY;
-const TCP = process.binding('tcp_wrap').TCP;
-const UDP = process.binding('udp_wrap').UDP;
+const { Process } = process.binding('process_wrap');
+const { WriteWrap } = process.binding('stream_wrap');
+const { Pipe } = process.binding('pipe_wrap');
+const { TTY } = process.binding('tty_wrap');
+const { TCP } = process.binding('tcp_wrap');
+const { UDP } = process.binding('udp_wrap');
 const SocketList = require('internal/socket_list');
 const { convertToValidSignal } = require('internal/util');
 const { isUint8Array } = require('internal/util/types');
@@ -30,8 +30,7 @@ const {
 } = process.binding('uv');
 
 const errnoException = util._errnoException;
-const SocketListSend = SocketList.SocketListSend;
-const SocketListReceive = SocketList.SocketListReceive;
+const { SocketListSend, SocketListReceive } = SocketList;
 
 const MAX_HANDLE_RETRANSMISSIONS = 3;
 
diff --git a/lib/internal/cluster/master.js b/lib/internal/cluster/master.js
index 4ccf039322..f3d2e30a5b 100644
--- a/lib/internal/cluster/master.js
+++ b/lib/internal/cluster/master.js
@@ -1,6 +1,6 @@
 'use strict';
 const assert = require('assert');
-const fork = require('child_process').fork;
+const { fork } = require('child_process');
 const util = require('util');
 const EventEmitter = require('events');
 const RoundRobinHandle = require('internal/cluster/round_robin_handle');
diff --git a/lib/internal/fs.js b/lib/internal/fs.js
index b8f710f04b..01c5ff4bfc 100644
--- a/lib/internal/fs.js
+++ b/lib/internal/fs.js
@@ -1,7 +1,7 @@
 'use strict';
 
-const Buffer = require('buffer').Buffer;
-const Writable = require('stream').Writable;
+const { Buffer } = require('buffer');
+const { Writable } = require('stream');
 const errors = require('internal/errors');
 const fs = require('fs');
 const util = require('util');
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
index 83db79b950..663672f052 100644
--- a/lib/internal/http2/core.js
+++ b/lib/internal/http2/core.js
@@ -6,7 +6,7 @@ require('internal/util').assertCrypto();
 
 const binding = process.binding('http2');
 const assert = require('assert');
-const Buffer = require('buffer').Buffer;
+const { Buffer } = require('buffer');
 const EventEmitter = require('events');
 const net = require('net');
 const tls = require('tls');
diff --git a/lib/internal/process/write-coverage.js b/lib/internal/process/write-coverage.js
index 50c55200d2..1657f5b470 100644
--- a/lib/internal/process/write-coverage.js
+++ b/lib/internal/process/write-coverage.js
@@ -1,9 +1,7 @@
 'use strict';
 const process = require('process');
 const path = require('path');
-const fs = require('fs');
-const mkdirSync = fs.mkdirSync;
-const writeFileSync = fs.writeFileSync;
+const { mkdirSync, writeFileSync } = require('fs');
 
 function writeCoverage() {
   if (!global.__coverage__) {
diff --git a/lib/internal/repl.js b/lib/internal/repl.js
index 1564dfd370..436e72cf75 100644
--- a/lib/internal/repl.js
+++ b/lib/internal/repl.js
@@ -1,6 +1,6 @@
 'use strict';
 
-const Interface = require('readline').Interface;
+const { Interface } = require('readline');
 const REPL = require('repl');
 const path = require('path');
 const fs = require('fs');
diff --git a/lib/internal/streams/BufferList.js b/lib/internal/streams/BufferList.js
index 6e724e9fb8..23d5a8a2db 100644
--- a/lib/internal/streams/BufferList.js
+++ b/lib/internal/streams/BufferList.js
@@ -1,6 +1,6 @@
 'use strict';
 
-const Buffer = require('buffer').Buffer;
+const { Buffer } = require('buffer');
 
 function copyBuffer(src, target, offset) {
   Buffer.prototype.copy.call(src, target, offset);
diff --git a/lib/internal/util.js b/lib/internal/util.js
index 3bae5b7f39..f2d4b1facd 100644
--- a/lib/internal/util.js
+++ b/lib/internal/util.js
@@ -2,7 +2,7 @@
 
 const errors = require('internal/errors');
 const binding = process.binding('util');
-const signals = process.binding('constants').os.signals;
+const { signals } = process.binding('constants').os;
 
 const { createPromise, promiseResolve, promiseReject } = binding;