fs: improve mode validation

Do not return a default mode in case invalid mode values are provided.
This strictens and simplifies the function by reusing existing
functionality.

PR-URL: https://github.com/nodejs/node/pull/26575
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 3 insertions, 10 deletions

diff --git a/lib/internal/validators.js b/lib/internal/validators.js
index 0ecf286266..6de46349c0 100644
--- a/lib/internal/validators.js
+++ b/lib/internal/validators.js
@@ -35,24 +35,17 @@ function validateMode(value, name, def) {
   }
 
   if (typeof value === 'number') {
-    if (!Number.isInteger(value)) {
-      throw new ERR_OUT_OF_RANGE(name, 'an integer', value);
-    } else {
-      // 2 ** 32 === 4294967296
-      throw new ERR_OUT_OF_RANGE(name, '>= 0 && < 4294967296', value);
-    }
+    validateInt32(value, name, 0, 2 ** 32 - 1);
   }
 
   if (typeof value === 'string') {
     if (!octalReg.test(value)) {
       throw new ERR_INVALID_ARG_VALUE(name, value, modeDesc);
     }
-    const parsed = parseInt(value, 8);
-    return parsed;
+    return parseInt(value, 8);
   }
 
-  // TODO(BridgeAR): Only return `def` in case `value == null`
-  if (def !== undefined) {
+  if (def !== undefined && value == null) {
     return def;
   }