util: adhere to `noDeprecation` set at runtime

Until now, the docs stated that `process.noDeprecation` could be set
at runtime, but before any modules were loaded. That was not true,
because `lib/internal/util.js` was loaded during the process startup
process, so setting the flag at runtime was pointless.

Minimal test case:

    process.noDeprecation = true;
    process.EventEmitter;

This patch moves checking `process.noDeprecation` to the place where
it was actually used.

PR-URL: https://github.com/nodejs/node/pull/6683
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 files changed, 1 insertions, 2 deletions

diff --git a/lib/internal/util.js b/lib/internal/util.js
index 56398ccf9d..9ecdf17ecd 100644
--- a/lib/internal/util.js
+++ b/lib/internal/util.js
@@ -2,7 +2,6 @@
 
 const binding = process.binding('util');
 const prefix = `(${process.release.name}:${process.pid}) `;
-const noDeprecation = process.noDeprecation;
 
 exports.getHiddenValue = binding.getHiddenValue;
 exports.setHiddenValue = binding.setHiddenValue;
@@ -16,7 +15,7 @@ exports.deprecate = function(fn, msg) {
 // All the internal deprecations have to use this function only, as this will
 // prepend the prefix to the actual message.
 exports.printDeprecationMessage = function(msg, warned, ctor) {
-  if (warned || noDeprecation)
+  if (warned || process.noDeprecation)
     return true;
   process.emitWarning(msg, 'DeprecationWarning',
                       ctor || exports.printDeprecationMessage);