summaryrefslogtreecommitdiff
path: root/lib/internal/util.js
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2019-06-20 07:13:26 +0800
committerJoyee Cheung <joyeec9h3@gmail.com>2019-06-27 20:22:08 +0800
commit94454927f697840a25c1ae73ebbcf9a5324b9060 (patch)
tree14d7579730ebbaf77d5f9b6945bbf408457b76e4 /lib/internal/util.js
parented8fc7e11d688cbcdf33d0d149830064758bdcd2 (diff)
downloadandroid-node-v8-94454927f697840a25c1ae73ebbcf9a5324b9060.tar.gz
android-node-v8-94454927f697840a25c1ae73ebbcf9a5324b9060.tar.bz2
android-node-v8-94454927f697840a25c1ae73ebbcf9a5324b9060.zip
process: split routines used to enhance fatal exception stack traces
Previously the enhancement were done right after emitting `'uncaughtException'`, which meant by the time we knew the exception was fatal in C++, the error.stack had already been patched. This patch moves those routines to be called later during the fatal exception handling, and split them into two stages: before and after the inspector is notified by the invocation of `V8Inspector::exceptionThrown`. We now expand the stack to include additional informations about unhandled 'error' events before the inspector is notified, but delay the highlighting of the frames until after the inspector is notified, so that the ANSI escape sequences won't show up in the inspector console. PR-URL: https://github.com/nodejs/node/pull/28308 Fixes: https://github.com/nodejs/node/issues/28287 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Diffstat (limited to 'lib/internal/util.js')
-rw-r--r--lib/internal/util.js1
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/internal/util.js b/lib/internal/util.js
index 931bcea5b4..67d4130ddd 100644
--- a/lib/internal/util.js
+++ b/lib/internal/util.js
@@ -414,6 +414,5 @@ module.exports = {
// Used by the buffer module to capture an internal reference to the
// default isEncoding implementation, just in case userland overrides it.
kIsEncodingSymbol: Symbol('kIsEncodingSymbol'),
- kExpandStackSymbol: Symbol('kExpandStackSymbol'),
kVmBreakFirstLineSymbol: Symbol('kVmBreakFirstLineSymbol')
};