summaryrefslogtreecommitdiff
path: root/lib/internal/streams/async_iterator.js
diff options
context:
space:
mode:
authorRobert Nagy <ronagy@icloud.com>2019-07-18 13:15:42 +0200
committerMatteo Collina <hello@matteocollina.com>2019-09-03 10:28:48 +0200
commitb03845b9376aec590b89f753a4b7c1b47729c5f8 (patch)
treebc16cf37f489fc97d715642941d4dd25b2e60d42 /lib/internal/streams/async_iterator.js
parentd62d2b456031539617a9e615c3e62c199a7e7dfe (diff)
downloadandroid-node-v8-b03845b9376aec590b89f753a4b7c1b47729c5f8.tar.gz
android-node-v8-b03845b9376aec590b89f753a4b7c1b47729c5f8.tar.bz2
android-node-v8-b03845b9376aec590b89f753a4b7c1b47729c5f8.zip
stream: make finished call the callback if the stream is closed
Make stream.finished callback invoked if stream is already closed/destroyed. PR-URL: https://github.com/nodejs/node/pull/28748 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'lib/internal/streams/async_iterator.js')
-rw-r--r--lib/internal/streams/async_iterator.js10
1 files changed, 0 insertions, 10 deletions
diff --git a/lib/internal/streams/async_iterator.js b/lib/internal/streams/async_iterator.js
index 07f2191e71..083befb89c 100644
--- a/lib/internal/streams/async_iterator.js
+++ b/lib/internal/streams/async_iterator.js
@@ -112,16 +112,6 @@ const ReadableStreamAsyncIteratorPrototype = Object.setPrototypeOf({
return() {
return new Promise((resolve, reject) => {
const stream = this[kStream];
-
- // TODO(ronag): Remove this check once finished() handles
- // already ended and/or destroyed streams.
- const ended = stream.destroyed || stream.readableEnded ||
- (stream._readableState && stream._readableState.endEmitted);
- if (ended) {
- resolve(createIterResult(undefined, true));
- return;
- }
-
finished(stream, (err) => {
if (err && err.code !== 'ERR_STREAM_PREMATURE_CLOSE') {
reject(err);