diff options
author | Rich Trott <rtrott@gmail.com> | 2019-03-12 11:09:48 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-03-14 13:03:20 -0700 |
commit | d78d33d6916dcf8c88949b953664f40a10111467 (patch) | |
tree | ba64aed48cf1a7cfc4aebddcf112edd7a34a03a0 /lib/internal/process | |
parent | 01b112a031a2f0c6390e541bbaaeb8e0d85c9e0b (diff) | |
download | android-node-v8-d78d33d6916dcf8c88949b953664f40a10111467.tar.gz android-node-v8-d78d33d6916dcf8c88949b953664f40a10111467.tar.bz2 android-node-v8-d78d33d6916dcf8c88949b953664f40a10111467.zip |
report: remove unnecessary return in setters
Barring shenanigans like Object.getOwnPropertyDescriptor(), return
values from a setter function will always be inaccessible. Remove
the `return` statements as they can be misleading, suggesting that the
return value is accessible and perhaps used somewhere.
PR-URL: https://github.com/nodejs/node/pull/26614
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/internal/process')
-rw-r--r-- | lib/internal/process/report.js | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/lib/internal/process/report.js b/lib/internal/process/report.js index ff4e72f54c..19820efa93 100644 --- a/lib/internal/process/report.js +++ b/lib/internal/process/report.js @@ -34,14 +34,14 @@ const report = { }, set directory(dir) { validateString(dir, 'directory'); - return nr.setDirectory(dir); + nr.setDirectory(dir); }, get filename() { return nr.getFilename(); }, set filename(name) { validateString(name, 'filename'); - return nr.setFilename(name); + nr.setFilename(name); }, get signal() { return nr.getSignal(); @@ -51,7 +51,7 @@ const report = { convertToValidSignal(sig); // Validate that the signal is recognized. removeSignalHandler(); addSignalHandler(sig); - return nr.setSignal(sig); + nr.setSignal(sig); }, get reportOnFatalError() { return nr.shouldReportOnFatalError(); @@ -60,7 +60,7 @@ const report = { if (typeof trigger !== 'boolean') throw new ERR_INVALID_ARG_TYPE('trigger', 'boolean', trigger); - return nr.setReportOnFatalError(trigger); + nr.setReportOnFatalError(trigger); }, get reportOnSignal() { return nr.shouldReportOnSignal(); @@ -80,7 +80,7 @@ const report = { if (typeof trigger !== 'boolean') throw new ERR_INVALID_ARG_TYPE('trigger', 'boolean', trigger); - return nr.setReportOnUncaughtException(trigger); + nr.setReportOnUncaughtException(trigger); } }; |