summaryrefslogtreecommitdiff
path: root/lib/internal/process
diff options
context:
space:
mode:
authorcjihrig <cjihrig@gmail.com>2019-03-05 08:41:51 -0500
committercjihrig <cjihrig@gmail.com>2019-03-05 15:36:06 -0500
commitcc4e8e0696ffd5813df9cb50af7b47c27aaf2712 (patch)
tree9b6f524dce6ebdeae9f63fe02397db140b365cee /lib/internal/process
parent30ee27784c935dd174238edecbd93edb4aab8972 (diff)
downloadandroid-node-v8-cc4e8e0696ffd5813df9cb50af7b47c27aaf2712.tar.gz
android-node-v8-cc4e8e0696ffd5813df9cb50af7b47c27aaf2712.tar.bz2
android-node-v8-cc4e8e0696ffd5813df9cb50af7b47c27aaf2712.zip
report: warn on process.report object access
Reduce the number of emitExperimentalWarning() call sites by making process.report emit a warning on access instead of each individual report function. PR-URL: https://github.com/nodejs/node/pull/26414 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Diffstat (limited to 'lib/internal/process')
-rw-r--r--lib/internal/process/report.js24
1 files changed, 1 insertions, 23 deletions
diff --git a/lib/internal/process/report.js b/lib/internal/process/report.js
index 96729b2ee3..c964431025 100644
--- a/lib/internal/process/report.js
+++ b/lib/internal/process/report.js
@@ -1,8 +1,5 @@
'use strict';
-const {
- convertToValidSignal,
- emitExperimentalWarning
-} = require('internal/util');
+const { convertToValidSignal } = require('internal/util');
const {
ERR_INVALID_ARG_TYPE,
ERR_SYNTHETIC
@@ -11,8 +8,6 @@ const { validateString } = require('internal/validators');
const nr = internalBinding('report');
const report = {
triggerReport(file, err) {
- emitExperimentalWarning('report');
-
if (typeof file === 'object' && file !== null) {
err = file;
file = undefined;
@@ -27,8 +22,6 @@ const report = {
return nr.triggerReport('JavaScript API', 'API', file, err.stack);
},
getReport(err) {
- emitExperimentalWarning('report');
-
if (err === undefined)
err = new ERR_SYNTHETIC();
else if (err === null || typeof err !== 'object')
@@ -37,29 +30,23 @@ const report = {
return nr.getReport(err.stack);
},
get directory() {
- emitExperimentalWarning('report');
return nr.getDirectory();
},
set directory(dir) {
- emitExperimentalWarning('report');
validateString(dir, 'directory');
return nr.setDirectory(dir);
},
get filename() {
- emitExperimentalWarning('report');
return nr.getFilename();
},
set filename(name) {
- emitExperimentalWarning('report');
validateString(name, 'filename');
return nr.setFilename(name);
},
get signal() {
- emitExperimentalWarning('report');
return nr.getSignal();
},
set signal(sig) {
- emitExperimentalWarning('report');
validateString(sig, 'signal');
convertToValidSignal(sig); // Validate that the signal is recognized.
removeSignalHandler();
@@ -67,24 +54,18 @@ const report = {
return nr.setSignal(sig);
},
get reportOnFatalError() {
- emitExperimentalWarning('report');
return nr.shouldReportOnFatalError();
},
set reportOnFatalError(trigger) {
- emitExperimentalWarning('report');
-
if (typeof trigger !== 'boolean')
throw new ERR_INVALID_ARG_TYPE('trigger', 'boolean', trigger);
return nr.setReportOnFatalError(trigger);
},
get reportOnSignal() {
- emitExperimentalWarning('report');
return nr.shouldReportOnSignal();
},
set reportOnSignal(trigger) {
- emitExperimentalWarning('report');
-
if (typeof trigger !== 'boolean')
throw new ERR_INVALID_ARG_TYPE('trigger', 'boolean', trigger);
@@ -93,12 +74,9 @@ const report = {
addSignalHandler();
},
get reportOnUncaughtException() {
- emitExperimentalWarning('report');
return nr.shouldReportOnUncaughtException();
},
set reportOnUncaughtException(trigger) {
- emitExperimentalWarning('report');
-
if (typeof trigger !== 'boolean')
throw new ERR_INVALID_ARG_TYPE('trigger', 'boolean', trigger);