diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-04-14 22:44:02 +0200 |
---|---|---|
committer | ZYSzys <zyszys98@gmail.com> | 2019-04-17 18:58:44 +0800 |
commit | d070f5d9659fbf562eaefac78ff7e8d4bedc1fd5 (patch) | |
tree | 99b91a269f2a3a4c16c2b55189fb7c418fffa448 /lib/internal/main | |
parent | 5450e48f6931d7960da88a96ddaab9f19dd4c788 (diff) | |
download | android-node-v8-d070f5d9659fbf562eaefac78ff7e8d4bedc1fd5.tar.gz android-node-v8-d070f5d9659fbf562eaefac78ff7e8d4bedc1fd5.tar.bz2 android-node-v8-d070f5d9659fbf562eaefac78ff7e8d4bedc1fd5.zip |
worker: improve coverage
This improves the worker coverage by using `internal/assert` instead
of relying on `assert` in case a faulty worker message type is
received.
PR-URL: https://github.com/nodejs/node/pull/27230
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'lib/internal/main')
-rw-r--r-- | lib/internal/main/worker_thread.js | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/lib/internal/main/worker_thread.js b/lib/internal/main/worker_thread.js index f290a4acb2..a06fda7a59 100644 --- a/lib/internal/main/worker_thread.js +++ b/lib/internal/main/worker_thread.js @@ -45,6 +45,8 @@ const { const publicWorker = require('worker_threads'); +const assert = require('internal/assert'); + patchProcessObject(); setupInspectorHooks(); setupDebugEnv(); @@ -122,18 +124,17 @@ port.on('message', (message) => { process.argv[1] = filename; // script filename require('module').runMain(); } - return; } else if (message.type === STDIO_PAYLOAD) { const { stream, chunk, encoding } = message; process[stream].push(chunk, encoding); - return; - } else if (message.type === STDIO_WANTS_MORE_DATA) { + } else { + assert( + message.type === STDIO_WANTS_MORE_DATA, + `Unknown worker message type ${message.type}` + ); const { stream } = message; process[stream][kStdioWantsMoreDataCallback](); - return; } - - require('assert').fail(`Unknown worker message type ${message.type}`); }); // Overwrite fatalException |