diff options
author | cjihrig <cjihrig@gmail.com> | 2019-08-17 11:50:43 -0400 |
---|---|---|
committer | cjihrig <cjihrig@gmail.com> | 2019-08-19 11:55:22 -0400 |
commit | 3238232fc46f6a8cc0dc1323aba762247c464e5e (patch) | |
tree | 428f6636855f08a5224204c319ec2d2f89ee4ae4 /lib/internal/fs | |
parent | 37321a9e11f2198d03a525cddca20827636b786c (diff) | |
download | android-node-v8-3238232fc46f6a8cc0dc1323aba762247c464e5e.tar.gz android-node-v8-3238232fc46f6a8cc0dc1323aba762247c464e5e.tar.bz2 android-node-v8-3238232fc46f6a8cc0dc1323aba762247c464e5e.zip |
lib: rename validateSafeInteger to validateInteger
validateInteger() was renamed to validateSafeInteger() in
https://github.com/nodejs/node/pull/26572. However, this
function also works with unsafe integers. This commit restores
the old name, and adds some basic tests.
PR-URL: https://github.com/nodejs/node/pull/29184
Refs: https://github.com/nodejs/node/pull/26572
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'lib/internal/fs')
-rw-r--r-- | lib/internal/fs/promises.js | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js index 6364fb6e9d..e796520b26 100644 --- a/lib/internal/fs/promises.js +++ b/lib/internal/fs/promises.js @@ -36,7 +36,7 @@ const { const { parseMode, validateBuffer, - validateSafeInteger, + validateInteger, validateUint32 } = require('internal/validators'); const pathModule = require('path'); @@ -209,7 +209,7 @@ async function read(handle, buffer, offset, length, position) { if (offset == null) { offset = 0; } else { - validateSafeInteger(offset, 'offset'); + validateInteger(offset, 'offset'); } length |= 0; @@ -243,7 +243,7 @@ async function write(handle, buffer, offset, length, position) { if (offset == null) { offset = 0; } else { - validateSafeInteger(offset, 'offset'); + validateInteger(offset, 'offset'); } if (typeof length !== 'number') length = buffer.length - offset; @@ -278,7 +278,7 @@ async function truncate(path, len = 0) { async function ftruncate(handle, len = 0) { validateFileHandle(handle); - validateSafeInteger(len, 'len'); + validateInteger(len, 'len'); len = Math.max(0, len); return binding.ftruncate(handle.fd, len, kUsePromises); } |