fs: use proper .destroy() implementation for SyncWriteStream

PR-URL: https://github.com/nodejs/node/pull/26690
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 5 insertions, 11 deletions

diff --git a/lib/internal/fs/sync_write_stream.js b/lib/internal/fs/sync_write_stream.js
index 1e7c6a50a9..0af289d7f4 100644
--- a/lib/internal/fs/sync_write_stream.js
+++ b/lib/internal/fs/sync_write_stream.js
@@ -4,15 +4,13 @@ const { Writable } = require('stream');
 const { closeSync, writeSync } = require('fs');
 
 function SyncWriteStream(fd, options) {
-  Writable.call(this);
+  Writable.call(this, { autoDestroy: true });
 
   options = options || {};
 
   this.fd = fd;
   this.readable = false;
   this.autoClose = options.autoClose === undefined ? true : options.autoClose;
-
-  this.on('end', () => this._destroy());
 }
 
 Object.setPrototypeOf(SyncWriteStream.prototype, Writable.prototype);
@@ -24,22 +22,18 @@ SyncWriteStream.prototype._write = function(chunk, encoding, cb) {
   return true;
 };
 
-SyncWriteStream.prototype._destroy = function() {
+SyncWriteStream.prototype._destroy = function(err, cb) {
   if (this.fd === null) // already destroy()ed
-    return;
+    return cb(err);
 
   if (this.autoClose)
     closeSync(this.fd);
 
   this.fd = null;
-  return true;
+  cb(err);
 };
 
 SyncWriteStream.prototype.destroySoon =
-SyncWriteStream.prototype.destroy = function() {
-  this._destroy();
-  this.emit('close');
-  return true;
-};
+  SyncWriteStream.prototype.destroy;
 
 module.exports = SyncWriteStream;