diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-11-30 17:55:48 +0100 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-12-05 16:53:58 +0100 |
commit | dcc82b37b631d636e0fefc8272c357ec4a7d6df2 (patch) | |
tree | 0a036ccfa7448c8d50628831084e9863a14a0766 /lib/internal/fs/streams.js | |
parent | 6ccc80c82a7e21bc9315d6fdccea62ce8e2712a7 (diff) | |
download | android-node-v8-dcc82b37b631d636e0fefc8272c357ec4a7d6df2.tar.gz android-node-v8-dcc82b37b631d636e0fefc8272c357ec4a7d6df2.tar.bz2 android-node-v8-dcc82b37b631d636e0fefc8272c357ec4a7d6df2.zip |
lib: remove `inherits()` usage
This switches all `util.inherits()` calls to use
`Object.setPrototypeOf()` instead. In fact, `util.inherits()` is
mainly a small wrapper around exactly this function while adding
the `_super` property on the object as well.
Refs: #24395
PR-URL: https://github.com/nodejs/node/pull/24755
Refs: https://github.com/nodejs/node/issues/24395
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'lib/internal/fs/streams.js')
-rw-r--r-- | lib/internal/fs/streams.js | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/internal/fs/streams.js b/lib/internal/fs/streams.js index 1eb3439f23..a79dfca9d5 100644 --- a/lib/internal/fs/streams.js +++ b/lib/internal/fs/streams.js @@ -17,7 +17,6 @@ const { } = require('internal/fs/utils'); const { Readable, Writable } = require('stream'); const { toPathIfFileURL } = require('internal/url'); -const util = require('util'); const kMinPoolSpace = 128; @@ -119,7 +118,7 @@ function ReadStream(path, options) { } }); } -util.inherits(ReadStream, Readable); +Object.setPrototypeOf(ReadStream.prototype, Readable.prototype); ReadStream.prototype.open = function() { fs.open(this.path, this.flags, this.mode, (er, fd) => { @@ -273,7 +272,7 @@ function WriteStream(path, options) { if (typeof this.fd !== 'number') this.open(); } -util.inherits(WriteStream, Writable); +Object.setPrototypeOf(WriteStream.prototype, Writable.prototype); WriteStream.prototype._final = function(callback) { if (this.autoClose) { |