summaryrefslogtreecommitdiff
path: root/lib/internal/fs/promises.js
diff options
context:
space:
mode:
authorСковорода Никита Андреевич <chalkerx@gmail.com>2018-05-06 12:13:56 +0300
committerСковорода Никита Андреевич <chalkerx@gmail.com>2018-05-19 11:04:28 +0300
commitc594d15170e6664c0609d317a9a201f34e875900 (patch)
treedd8b62eccab6545e91924ce0132a7537a5b802b0 /lib/internal/fs/promises.js
parent064057b7ad0ee6f76f43846b4f002072dafa1702 (diff)
downloadandroid-node-v8-c594d15170e6664c0609d317a9a201f34e875900.tar.gz
android-node-v8-c594d15170e6664c0609d317a9a201f34e875900.tar.bz2
android-node-v8-c594d15170e6664c0609d317a9a201f34e875900.zip
fs: drop duplicate API in promises mode
This drops exporting duplicate methods that accept FileHandle as the first argument (to mirror callback-based methods accepting 'fd'). Those methods were not adding actual value to the API because all of those are already present as FileHandle methods, and they would probably be confusing to the new users and making docs harder to read. Also, the API was a bit inconsistent and lacked .close(handle). Fixes: https://github.com/nodejs/node/issues/20548 PR-URL: https://github.com/nodejs/node/pull/20559 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'lib/internal/fs/promises.js')
-rw-r--r--lib/internal/fs/promises.js9
1 files changed, 0 insertions, 9 deletions
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
index ee985761ac..9700765f08 100644
--- a/lib/internal/fs/promises.js
+++ b/lib/internal/fs/promises.js
@@ -466,31 +466,22 @@ module.exports = {
access,
copyFile,
open,
- read,
- write,
rename,
truncate,
- ftruncate,
rmdir,
- fdatasync,
- fsync,
mkdir,
readdir,
readlink,
symlink,
- fstat,
lstat,
stat,
link,
unlink,
- fchmod,
chmod,
lchmod,
lchown,
- fchown,
chown,
utimes,
- futimes,
realpath,
mkdtemp,
writeFile,