diff options
| author | cjihrig <cjihrig@gmail.com> | 2019-03-07 09:13:40 -0500 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2019-03-10 15:50:16 -0400 |
| commit | 31947449e30a8bc46ebf94d426ad09b9ad718b40 (patch) | |
| tree | e9d7f63e5ba5450f09668aac38cdb1ce0f2d4518 /lib/internal/errors.js | |
| parent | fb54968ce3f76a057c72783a7a0e4a24c492e124 (diff) | |
| download | android-node-v8-31947449e30a8bc46ebf94d426ad09b9ad718b40.tar.gz android-node-v8-31947449e30a8bc46ebf94d426ad09b9ad718b40.tar.bz2 android-node-v8-31947449e30a8bc46ebf94d426ad09b9ad718b40.zip | |
doc: document fake ENOTFOUND as a system error
PR-URL: https://github.com/nodejs/node/pull/26495
Fixes: https://github.com/nodejs/node/issues/26484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/internal/errors.js')
| -rw-r--r-- | lib/internal/errors.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/internal/errors.js b/lib/internal/errors.js index b3b745252a..a76153297e 100644 --- a/lib/internal/errors.js +++ b/lib/internal/errors.js @@ -432,8 +432,8 @@ function dnsException(code, syscall, hostname) { // If `code` is of type number, it is a libuv error number, else it is a // c-ares error code. if (typeof code === 'number') { - // FIXME(bnoordhuis) Remove this backwards compatibility nonsense and pass - // the true error to the user. ENOTFOUND is not even a proper POSIX error! + // ENOTFOUND is not a proper POSIX error, but this error has been in place + // long enough that it's not practical to remove it. if (code === lazyUv().UV_EAI_NODATA || code === lazyUv().UV_EAI_NONAME) { code = 'ENOTFOUND'; // Fabricated error name. } else { |