diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-20 13:15:48 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-27 17:05:19 +0100 |
commit | 7bddfcc61a5a7d04583a8c4fec462ca5ce45b677 (patch) | |
tree | 0ed6a369fdb71c84281ae830b24ab78da6bce3f7 /lib/internal/crypto | |
parent | 751c92d9728da6f6f86e443783a61253791cfc2f (diff) | |
download | android-node-v8-7bddfcc61a5a7d04583a8c4fec462ca5ce45b677.tar.gz android-node-v8-7bddfcc61a5a7d04583a8c4fec462ca5ce45b677.tar.bz2 android-node-v8-7bddfcc61a5a7d04583a8c4fec462ca5ce45b677.zip |
lib: consolidate arrayBufferView validation
There are lots of places that validate for arrayBufferView and we
have multiple functions that do the same thing. Instead, move the
validation into `internal/validators` so all files can use that
instead.
There are more functions throughout the code that do the same but
it takes some more work to fully consolidate all of those.
PR-URL: https://github.com/nodejs/node/pull/26809
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/internal/crypto')
-rw-r--r-- | lib/internal/crypto/certificate.js | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/lib/internal/crypto/certificate.js b/lib/internal/crypto/certificate.js index 29372ca497..d828bef0f6 100644 --- a/lib/internal/crypto/certificate.js +++ b/lib/internal/crypto/certificate.js @@ -5,6 +5,9 @@ const { certExportPublicKey, certVerifySpkac } = internalBinding('crypto'); +const { + validateBuffer +} = require('internal/validators'); const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes; const { isArrayBufferView } = require('internal/util/types'); @@ -14,13 +17,7 @@ const { } = require('internal/crypto/util'); function verifySpkac(spkac) { - if (!isArrayBufferView(spkac)) { - throw new ERR_INVALID_ARG_TYPE( - 'spkac', - ['Buffer', 'TypedArray', 'DataView'], - spkac - ); - } + validateBuffer(spkac, 'spkac'); return certVerifySpkac(spkac); } |