summaryrefslogtreecommitdiff
path: root/lib/internal/crypto
diff options
context:
space:
mode:
authorTobias Nießen <tniessen@tnie.de>2018-10-09 09:36:46 +1100
committerTobias Nießen <tniessen@tnie.de>2019-09-25 15:58:15 -0300
commit61743063cccf5b9ec6e1bc85f453bf9d3f83250a (patch)
tree3565076af52faee203bf55c878af2f64bcd81b12 /lib/internal/crypto
parent7333c7163abdf58ffddb8dcbd3f0b43ad1885fdc (diff)
downloadandroid-node-v8-61743063cccf5b9ec6e1bc85f453bf9d3f83250a.tar.gz
android-node-v8-61743063cccf5b9ec6e1bc85f453bf9d3f83250a.tar.bz2
android-node-v8-61743063cccf5b9ec6e1bc85f453bf9d3f83250a.zip
crypto: use byteLength in timingSafeEqual
PR-URL: https://github.com/nodejs/node/pull/29657 Co-authored-by: ZaneHannanAU <ZaneHannanAU@users.noreply.github.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Diffstat (limited to 'lib/internal/crypto')
-rw-r--r--lib/internal/crypto/util.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/internal/crypto/util.js b/lib/internal/crypto/util.js
index ddef1a163c..544d44669a 100644
--- a/lib/internal/crypto/util.js
+++ b/lib/internal/crypto/util.js
@@ -78,7 +78,7 @@ function timingSafeEqual(buf1, buf2) {
throw new ERR_INVALID_ARG_TYPE('buf2',
['Buffer', 'TypedArray', 'DataView'], buf2);
}
- if (buf1.length !== buf2.length) {
+ if (buf1.byteLength !== buf2.byteLength) {
throw new ERR_CRYPTO_TIMING_SAFE_EQUAL_LENGTH();
}
return _timingSafeEqual(buf1, buf2);