diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-11-26 19:38:02 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-28 05:01:56 -0800 |
| commit | 51f07ffc841d44c712edc9610529334897b3de26 (patch) | |
| tree | 93a268ba4a400e8b265695283ba60d6233135228 /lib/internal/child_process.js | |
| parent | 89e8fc4520d094281b43d95d60e6c317e056a3a4 (diff) | |
| download | android-node-v8-51f07ffc841d44c712edc9610529334897b3de26.tar.gz android-node-v8-51f07ffc841d44c712edc9610529334897b3de26.tar.bz2 android-node-v8-51f07ffc841d44c712edc9610529334897b3de26.zip | |
test: make test-uv-binding-constant JS engine neutral
The error message validation in test-uv-binding-constant depends on the
JS engine. The text will be different in node-chakracore than in
V8-based versions of Node.js. Remove the message validation. Test that
it is a TypeError only. We should only validate error messages when we
control the contents of that error message (and not even necessarily
then, but that is a minimum requirement). V8 and other underlying
engines can change the error message at any time and that should not
require us to change our tests (as changing tests suggests a
semver-major change).
PR-URL: https://github.com/nodejs/node/pull/24666
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'lib/internal/child_process.js')
0 files changed, 0 insertions, 0 deletions