summaryrefslogtreecommitdiff
path: root/lib/internal/bootstrap
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2019-03-06 12:05:23 +0100
committerJoyee Cheung <joyeec9h3@gmail.com>2019-03-08 13:53:50 +0100
commitd7543a79d6949213950a60393d3bc16d18a6ae29 (patch)
tree21c00ce7652aa89eee7598eabc2f5b6dc83039f9 /lib/internal/bootstrap
parentf9b76c3bf4d8937ef556d27966e64c56a65a4ee7 (diff)
downloadandroid-node-v8-d7543a79d6949213950a60393d3bc16d18a6ae29.tar.gz
android-node-v8-d7543a79d6949213950a60393d3bc16d18a6ae29.tar.bz2
android-node-v8-d7543a79d6949213950a60393d3bc16d18a6ae29.zip
process: set up process warning handler in pre-execution
Since it depends on environment variables. PR-URL: https://github.com/nodejs/node/pull/26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'lib/internal/bootstrap')
-rw-r--r--lib/internal/bootstrap/node.js5
-rw-r--r--lib/internal/bootstrap/pre_execution.js12
2 files changed, 13 insertions, 4 deletions
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index aa6c6b262a..f04bfe23fb 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -115,12 +115,9 @@ if (isMainThread) {
}
const {
- onWarning,
emitWarning
} = NativeModule.require('internal/process/warning');
-if (!process.noProcessWarnings && process.env.NODE_NO_WARNINGS !== '1') {
- process.on('warning', onWarning);
-}
+
process.emitWarning = emitWarning;
const {
diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
index 1ba6c7a758..9dc93a5478 100644
--- a/lib/internal/bootstrap/pre_execution.js
+++ b/lib/internal/bootstrap/pre_execution.js
@@ -8,6 +8,8 @@ let traceEventsAsyncHook;
function prepareMainThreadExecution() {
setupTraceCategoryState();
+ setupWarningHandler();
+
// Only main thread receives signals.
setupSignalHandlers();
@@ -36,6 +38,15 @@ function prepareMainThreadExecution() {
loadPreloadModules();
}
+function setupWarningHandler() {
+ const {
+ onWarning
+ } = require('internal/process/warning');
+ if (!process.noProcessWarnings && process.env.NODE_NO_WARNINGS !== '1') {
+ process.on('warning', onWarning);
+ }
+}
+
function initializeReport() {
if (!getOptionValue('--experimental-report')) {
return;
@@ -245,6 +256,7 @@ function loadPreloadModules() {
}
module.exports = {
+ setupWarningHandler,
prepareMainThreadExecution,
initializeDeprecations,
initializeESMLoader,