process: refactor coverage setup during bootstrap

- Renamed `internal/process/write-coverage.js` to
  `internal/coverage-gen/with_instrumentation.js`,
  `internal/process/coverage.js` to
  `internal/coverage-gen/with_profiler.js` to distinguish
  the two better and added comments.
- Separate the coverage directory setup and the connection
  setup, moves the directory setup into `node.js` and
  closer to the exit hooks because that's where it's used.
- Moves the `process.reallyExit` overwrite and
  `process.on('exit')` hooks setup into bootstrap/node.js
  for clarity, and move them to a later stage of
  bootstrap since they do not have to happen that early.

PR-URL: https://github.com/nodejs/node/pull/25398
Reviewed-By: Ben Coe <bencoe@gmail.com>

1 files changed, 8 insertions, 1 deletions

diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
index 300a362abb..4554526298 100644
--- a/lib/internal/bootstrap/loaders.js
+++ b/lib/internal/bootstrap/loaders.js
@@ -329,7 +329,14 @@ NativeModule.prototype.compile = function() {
 // Coverage must be turned on early, so that we can collect
 // it for Node.js' own internal libraries.
 if (process.env.NODE_V8_COVERAGE) {
-  NativeModule.require('internal/process/coverage').setup();
+  if (internalBinding('config').hasInspector) {
+    const coverage =
+      NativeModule.require('internal/coverage-gen/with_profiler');
+    // Inform the profiler to start collecting coverage
+    coverage.startCoverageCollection();
+  } else {
+    process._rawDebug('NODE_V8_COVERAGE cannot be used without inspector');
+  }
 }
 
 function internalBindingWhitelistHas(name) {