diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-18 03:47:55 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-23 02:55:55 +0100 |
| commit | 3fe1e80896d69b2125e3a264d0707fdbc6f37740 (patch) | |
| tree | 8e909c53a2cdf52650504f21467e9961d2aec6ef /lib/events.js | |
| parent | bfbce289c33b12aafb82bd5b45bcb4412850b28f (diff) | |
| download | android-node-v8-3fe1e80896d69b2125e3a264d0707fdbc6f37740.tar.gz android-node-v8-3fe1e80896d69b2125e3a264d0707fdbc6f37740.tar.bz2 android-node-v8-3fe1e80896d69b2125e3a264d0707fdbc6f37740.zip | |
lib: validate Error.captureStackTrace() calls
This adds a custom eslint rule to verify that
`Error.captureStackTrace()` is only called if necessary. In most
cases the helper function should be used instead.
PR-URL: https://github.com/nodejs/node/pull/26738
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'lib/events.js')
| -rw-r--r-- | lib/events.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/events.js b/lib/events.js index 8a676773b6..6a141f44d8 100644 --- a/lib/events.js +++ b/lib/events.js @@ -158,6 +158,7 @@ EventEmitter.prototype.emit = function emit(type, ...args) { try { const { kExpandStackSymbol } = require('internal/util'); const capture = {}; + // eslint-disable-next-line no-restricted-syntax Error.captureStackTrace(capture, EventEmitter.prototype.emit); Object.defineProperty(er, kExpandStackSymbol, { value: enhanceStackTrace.bind(null, er, capture), |