diff options
| author | ohbarye <over.rye@gmail.com> | 2018-05-12 02:26:28 +0900 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-18 15:53:06 +0200 |
| commit | 0c852a1795c0f5886c5bf5e8fa20e76456e78222 (patch) | |
| tree | f507b9198198a3fe240f4df929c4cad35d808c69 /lib/console.js | |
| parent | 60cc8ff096c98c3bfd5c4906ac9af3e9c220a748 (diff) | |
| download | android-node-v8-0c852a1795c0f5886c5bf5e8fa20e76456e78222.tar.gz android-node-v8-0c852a1795c0f5886c5bf5e8fa20e76456e78222.tar.bz2 android-node-v8-0c852a1795c0f5886c5bf5e8fa20e76456e78222.zip | |
console: .table fall back to logging for function too
According to the console.table documentation, it reads that it "falls
back to just logging the argument if it can’t be parsed as tabular."
But it doesn't fall back when I give a function as its first argument.
It logs an empty table. This is fixes by this commit.
PR-URL: https://github.com/nodejs/node/pull/20681
Fixes: https://github.com/nodejs/node/issues/20679
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'lib/console.js')
| -rw-r--r-- | lib/console.js | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/console.js b/lib/console.js index 868b2f286b..de2d11afe1 100644 --- a/lib/console.js +++ b/lib/console.js @@ -327,8 +327,7 @@ Console.prototype.table = function(tabularData, properties) { if (properties !== undefined && !ArrayIsArray(properties)) throw new ERR_INVALID_ARG_TYPE('properties', 'Array', properties); - if (tabularData == null || - (typeof tabularData !== 'object' && typeof tabularData !== 'function')) + if (tabularData == null || typeof tabularData !== 'object') return this.log(tabularData); if (cliTable === undefined) cliTable = require('internal/cli_table'); |