diff options
author | Evan Lucas <evanlucas@me.com> | 2016-06-02 06:45:33 -0500 |
---|---|---|
committer | Evan Lucas <evanlucas@me.com> | 2016-06-05 16:04:44 -0500 |
commit | f44b18f010d3548f8429afd415eee0a034bedbf4 (patch) | |
tree | ca53fbfd3b0cc026b8b8403f95f77c3f7ebcf10a /lib/cluster.js | |
parent | abd0d68bea82e6f22c1eaf28257cc6b33136cdbe (diff) | |
download | android-node-v8-f44b18f010d3548f8429afd415eee0a034bedbf4.tar.gz android-node-v8-f44b18f010d3548f8429afd415eee0a034bedbf4.tar.bz2 android-node-v8-f44b18f010d3548f8429afd415eee0a034bedbf4.zip |
cluster: deprecate worker.suicide
Deprecate worker.suicide in favor of worker.exitedAfterDisconnect.
PR-URL: https://github.com/nodejs/node/pull/3747
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Diffstat (limited to 'lib/cluster.js')
-rw-r--r-- | lib/cluster.js | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/lib/cluster.js b/lib/cluster.js index 34f27d0c12..228ad0dfe2 100644 --- a/lib/cluster.js +++ b/lib/cluster.js @@ -6,6 +6,7 @@ const dgram = require('dgram'); const fork = require('child_process').fork; const net = require('net'); const util = require('util'); +const internalUtil = require('internal/util'); const SCHED_NONE = 1; const SCHED_RR = 2; @@ -30,14 +31,14 @@ function Worker(options) { this.exitedAfterDisconnect = undefined; Object.defineProperty(this, 'suicide', { - get: function() { - // TODO: Print deprecation message. + get: internalUtil.deprecate(() => { return this.exitedAfterDisconnect; - }, - set: function(val) { - // TODO: Print deprecation message. + }, 'worker.suicide is deprecated. ' + + 'Please use worker.exitedAfterDisconnect.'), + set: internalUtil.deprecate((val) => { this.exitedAfterDisconnect = val; - }, + }, 'worker.suicide is deprecated. ' + + 'Please use worker.exitedAfterDisconnect.'), enumerable: true }); |