diff options
| author | Anatoli Papirovski <apapirovski@mac.com> | 2018-01-17 13:30:43 -0500 |
|---|---|---|
| committer | Anatoli Papirovski <apapirovski@mac.com> | 2018-01-18 08:04:06 -0500 |
| commit | 38ee25e2e205270c6ff258742aa34b442d9bc580 (patch) | |
| tree | 67444236a0fb7c814d7bb96c9c8c7608a949c44a /lib/child_process.js | |
| parent | 359a23234892acc6f481f5c90ca27c2435e32a01 (diff) | |
| download | android-node-v8-38ee25e2e205270c6ff258742aa34b442d9bc580.tar.gz android-node-v8-38ee25e2e205270c6ff258742aa34b442d9bc580.tar.bz2 android-node-v8-38ee25e2e205270c6ff258742aa34b442d9bc580.zip | |
child_process: do not ignore proto values of env
This reverts this behaviour introduced in a recent PR, and updates
the test. Without this change, CitGM and other packages are broken.
PR-URL: https://github.com/nodejs/node/pull/18210
Fixes: https://github.com/nodejs/citgm/issues/536
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Diffstat (limited to 'lib/child_process.js')
| -rw-r--r-- | lib/child_process.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/child_process.js b/lib/child_process.js index f2c1a0c237..00d1bfc57d 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -504,7 +504,8 @@ function normalizeSpawnArguments(file, args, options) { var env = options.env || process.env; var envPairs = []; - for (const key of Object.keys(env)) { + // Prototype values are intentionally included. + for (var key in env) { const value = env[key]; if (value !== undefined) { envPairs.push(`${key}=${value}`); |