diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-07-07 22:59:36 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2017-07-11 18:25:09 -0700 |
| commit | e6e6b07e512dd4e71b0458cb02901ce6d5398e29 (patch) | |
| tree | 10fd87dc62960789beb8f441330c1c5cf314e325 /lib/buffer.js | |
| parent | 80c9fd956917932930b58b3bdc5720fa8f51a21e (diff) | |
| download | android-node-v8-e6e6b07e512dd4e71b0458cb02901ce6d5398e29.tar.gz android-node-v8-e6e6b07e512dd4e71b0458cb02901ce6d5398e29.tar.bz2 android-node-v8-e6e6b07e512dd4e71b0458cb02901ce6d5398e29.zip | |
buffer: remove MAX_SAFE_INTEGER check on length
MAX_SAFE_INTEGER is millions of times larger than the largest buffer
allowed in Node.js. There is no need to squash the length down to
MAX_SAFE_INTEGER. Removing that check results in a small but
statistically significant increase for Buffer.from() operating on
ArrayBuffers in some situations.
PR-URL: https://github.com/nodejs/node/pull/14131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Diffstat (limited to 'lib/buffer.js')
| -rw-r--r-- | lib/buffer.js | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/buffer.js b/lib/buffer.js index cfe3080810..f8d615ee0c 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -354,8 +354,6 @@ function fromArrayBuffer(obj, byteOffset, length) { if (length !== length) { length = 0; } else if (length > 0) { - length = (length < Number.MAX_SAFE_INTEGER ? - length : Number.MAX_SAFE_INTEGER); if (length > maxLength) throw new RangeError("'length' is out of bounds"); } else { |