diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-13 00:58:22 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-16 18:09:55 +0100 |
commit | 43b8ce4ce741a8a6a435e4073ca5a9ec188d4515 (patch) | |
tree | 9d02df93c47e93e610400a2732f9fd00ad5b99cb /lib/buffer.js | |
parent | ef0e92eb827cad86c327ad0b528fa6960e2060e0 (diff) | |
download | android-node-v8-43b8ce4ce741a8a6a435e4073ca5a9ec188d4515.tar.gz android-node-v8-43b8ce4ce741a8a6a435e4073ca5a9ec188d4515.tar.bz2 android-node-v8-43b8ce4ce741a8a6a435e4073ca5a9ec188d4515.zip |
buffer: remove obsolete NaN check
These two NaN entries are not necessary and we can safely remove them.
PR-URL: https://github.com/nodejs/node/pull/18744
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'lib/buffer.js')
-rw-r--r-- | lib/buffer.js | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/lib/buffer.js b/lib/buffer.js index edebf901aa..01e605f50a 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -378,10 +378,7 @@ function fromArrayBuffer(obj, byteOffset, length) { } else { // convert length to non-negative integer length = +length; - // Check for NaN - if (length !== length) { - length = 0; - } else if (length > 0) { + if (length > 0) { if (length > maxLength) throw new errors.RangeError('ERR_BUFFER_OUT_OF_BOUNDS', 'length'); } else { @@ -404,7 +401,7 @@ function fromObject(obj) { } if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) { - if (typeof obj.length !== 'number' || obj.length !== obj.length) { + if (typeof obj.length !== 'number') { return new FastBuffer(); } return fromArrayLike(obj); |