summaryrefslogtreecommitdiff
path: root/lib/assert.js
diff options
context:
space:
mode:
authorRuslan Bekenev <furyinbox@gmail.com>2017-04-02 20:11:42 +0300
committerRefael Ackermann <refack@gmail.com>2017-07-19 15:53:26 -0400
commitc53db1e8e9bb65779d791046daa39ed88c8f1045 (patch)
tree79cffe6840764d8e236e76120141cfd7bca167fa /lib/assert.js
parent2a621d40517b8ec17d6b6b15e31bdc6e5d34e768 (diff)
downloadandroid-node-v8-c53db1e8e9bb65779d791046daa39ed88c8f1045.tar.gz
android-node-v8-c53db1e8e9bb65779d791046daa39ed88c8f1045.tar.bz2
android-node-v8-c53db1e8e9bb65779d791046daa39ed88c8f1045.zip
assert: show thrown message in doesNotThrow()
assert.doesNotThrow() should show actual error message instead of "Got unwanted exception" which is not really helpful. PR-URL: https://github.com/nodejs/node/pull/12167 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'lib/assert.js')
-rw-r--r--lib/assert.js5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/assert.js b/lib/assert.js
index b66061b29b..a948028501 100644
--- a/lib/assert.js
+++ b/lib/assert.js
@@ -546,7 +546,10 @@ function innerThrows(shouldThrow, block, expected, message) {
} else if (actual !== undefined) {
if (!expected || expectedException(actual, expected)) {
details = message ? `: ${message}` : '.';
- fail(actual, expected, `Got unwanted exception${details}`, fail);
+ fail(actual,
+ expected,
+ `Got unwanted exception${details}\n${actual.message}`,
+ fail);
}
throw actual;
}