lib: faster type checks for some types

PR-URL: https://github.com/nodejs/node/pull/15663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 3 insertions, 2 deletions

diff --git a/lib/assert.js b/lib/assert.js
index 2aaf80eecc..a29408f47e 100644
--- a/lib/assert.js
+++ b/lib/assert.js
@@ -23,6 +23,7 @@
 const { compare } = process.binding('buffer');
 const { isSet, isMap, isDate, isRegExp } = process.binding('util');
 const { objectToString } = require('internal/util');
+const { isArrayBufferView } = require('internal/util/types');
 const errors = require('internal/errors');
 const { propertyIsEnumerable } = Object.prototype;
 
@@ -209,7 +210,7 @@ function strictDeepEqual(actual, expected, memos) {
     if (actual.message !== expected.message) {
       return false;
     }
-  } else if (ArrayBuffer.isView(actual)) {
+  } else if (isArrayBufferView(actual)) {
     if (!areSimilarTypedArrays(actual, expected,
                                isFloatTypedArrayTag(actualTag) ? 0 : 300)) {
       return false;
@@ -262,7 +263,7 @@ function looseDeepEqual(actual, expected, memos) {
   const actualTag = objectToString(actual);
   const expectedTag = objectToString(expected);
   if (actualTag === expectedTag) {
-    if (!isObjectOrArrayTag(actualTag) && ArrayBuffer.isView(actual)) {
+    if (!isObjectOrArrayTag(actualTag) && isArrayBufferView(actual)) {
       return areSimilarTypedArrays(actual, expected,
                                    isFloatTypedArrayTag(actualTag) ?
                                      Infinity : 300);