summaryrefslogtreecommitdiff
path: root/lib/_tls_wrap.js
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2018-02-25 21:43:23 +0100
committerAnatoli Papirovski <apapirovski@mac.com>2018-03-04 12:43:13 +0100
commiteda702104b3447dd56dc635565b4c88b0e04685a (patch)
treef5cddcddb7102965c8f4d2ac10e4da4e89d07390 /lib/_tls_wrap.js
parent1ebd966d2cef9d026b947c3c36d49c9989a60701 (diff)
downloadandroid-node-v8-eda702104b3447dd56dc635565b4c88b0e04685a.tar.gz
android-node-v8-eda702104b3447dd56dc635565b4c88b0e04685a.tar.bz2
android-node-v8-eda702104b3447dd56dc635565b4c88b0e04685a.zip
tls: better error message for socket disconnect
The error emitted when a connection is closed before the TLS handshake completes seemed rather unspefic by just saying `socket hang up`. Use a more verbose message, that also indicates that this is a purely client-side error, and remove a misleading comment. PR-URL: https://github.com/nodejs/node/pull/18989 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'lib/_tls_wrap.js')
-rw-r--r--lib/_tls_wrap.js4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
index b3c48b950c..c472564270 100644
--- a/lib/_tls_wrap.js
+++ b/lib/_tls_wrap.js
@@ -1074,7 +1074,6 @@ function onConnectSecure() {
this.emit('secureConnect');
}
- // Uncork incoming data
this.removeListener('end', onConnectEnd);
}
@@ -1083,7 +1082,8 @@ function onConnectEnd() {
if (!this._hadError) {
const options = this[kConnectOptions];
this._hadError = true;
- const error = new Error('socket hang up');
+ const error = new Error('Client network socket disconnected before ' +
+ 'secure TLS connection was established');
error.code = 'ECONNRESET';
error.path = options.path;
error.host = options.host;