crypto: throw if the key doesn't match cert

fix joyent/node#8770
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/node-forward/node/pull/66

1 files changed, 23 insertions, 19 deletions

diff --git a/lib/_tls_common.js b/lib/_tls_common.js
index e66ae662fe..a3309ead0a 100644
--- a/lib/_tls_common.js
+++ b/lib/_tls_common.js
@@ -65,25 +65,6 @@ exports.createSecureContext = function createSecureContext(options, context) {
 
   if (context) return c;
 
-  if (options.key) {
-    if (Array.isArray(options.key)) {
-      for (var i = 0; i < options.key.length; i++) {
-        var key = options.key[i];
-
-        if (key.passphrase)
-          c.context.setKey(key.pem, key.passphrase);
-        else
-          c.context.setKey(key);
-      }
-    } else {
-      if (options.passphrase) {
-        c.context.setKey(options.key, options.passphrase);
-      } else {
-        c.context.setKey(options.key);
-      }
-    }
-  }
-
   // NOTE: It's important to add CA before the cert to be able to load
   // cert's issuer in C++ code.
   if (options.ca) {
@@ -107,6 +88,29 @@ exports.createSecureContext = function createSecureContext(options, context) {
     }
   }
 
+  // NOTE: It is important to set the key after the cert.
+  // `ssl_set_pkey` returns `0` when the key does not much the cert, but
+  // `ssl_set_cert` returns `1` and nullifies the key in the SSL structure
+  // which leads to the crash later on.
+  if (options.key) {
+    if (Array.isArray(options.key)) {
+      for (var i = 0; i < options.key.length; i++) {
+        var key = options.key[i];
+
+        if (key.passphrase)
+          c.context.setKey(key.pem, key.passphrase);
+        else
+          c.context.setKey(key);
+      }
+    } else {
+      if (options.passphrase) {
+        c.context.setKey(options.key, options.passphrase);
+      } else {
+        c.context.setKey(options.key);
+      }
+    }
+  }
+
   if (options.ciphers)
     c.context.setCiphers(options.ciphers);
   else