summaryrefslogtreecommitdiff
path: root/lib/_tls_common.js
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2019-10-24 15:19:07 -0700
committerRich Trott <rtrott@gmail.com>2019-10-26 16:33:24 -0700
commit72346bd8d43477273419049ab68a5c6611480a92 (patch)
tree5519d5ba59ed5d9764de18990eff72f152faafd9 /lib/_tls_common.js
parentab78d4df34a7698c45fca0b81300fd02fc4add7b (diff)
downloadandroid-node-v8-72346bd8d43477273419049ab68a5c6611480a92.tar.gz
android-node-v8-72346bd8d43477273419049ab68a5c6611480a92.tar.bz2
android-node-v8-72346bd8d43477273419049ab68a5c6611480a92.zip
doc: remove "it is important to" phrasing
Instead of telling someone "It is important to do X", just tell them to "Do X." PR-URL: https://github.com/nodejs/node/pull/30108 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/_tls_common.js')
-rw-r--r--lib/_tls_common.js5
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/_tls_common.js b/lib/_tls_common.js
index 6cd93036c2..ef67d23ac8 100644
--- a/lib/_tls_common.js
+++ b/lib/_tls_common.js
@@ -100,8 +100,7 @@ exports.createSecureContext = function createSecureContext(options) {
var i;
var val;
- // NOTE: It's important to add CA before the cert to be able to load
- // cert's issuer in C++ code.
+ // Add CA before the cert to be able to load cert's issuer in C++ code.
const { ca } = options;
if (ca) {
if (Array.isArray(ca)) {
@@ -132,7 +131,7 @@ exports.createSecureContext = function createSecureContext(options) {
}
}
- // NOTE: It is important to set the key after the cert.
+ // Set the key after the cert.
// `ssl_set_pkey` returns `0` when the key does not match the cert, but
// `ssl_set_cert` returns `1` and nullifies the key in the SSL structure
// which leads to the crash later on.