summaryrefslogtreecommitdiff
path: root/lib/_tls_common.js
diff options
context:
space:
mode:
authorSam Roberts <vieuxtech@gmail.com>2018-11-07 16:18:03 -0800
committerRich Trott <rtrott@gmail.com>2018-11-09 18:28:05 -0800
commit624a242b05397fdacc1e79007de223cd0331f6e8 (patch)
tree668a1c623679e7842f97b7df0b47c1be5dfa6239 /lib/_tls_common.js
parent3ffc84a46de9cf623ac680bff72445e372935376 (diff)
downloadandroid-node-v8-624a242b05397fdacc1e79007de223cd0331f6e8.tar.gz
android-node-v8-624a242b05397fdacc1e79007de223cd0331f6e8.tar.bz2
android-node-v8-624a242b05397fdacc1e79007de223cd0331f6e8.zip
test: simplify regression test for SEGV
Test was introduced in 08a5b442e4 as a regression test, and has evolved since then. Simplify the test so that it doesn't rely on an undocumented argument to tls.createSecureCredentials(). See: https://github.com/nodejs/node-v0.x-archive/issues/6690 Confirmation that this reworked test triggers the original bug: %) % node > process.version 'v0.10.48' > credentials = crypto.createCredentials() { context: {} } > context = credentials.context {} > notcontext = { setOptions: context.setOptions } { setOptions: [Function: setOptions] } > notcontext.setOptions() node: ../src/node_object_wrap.h:61: static T* node::ObjectWrap::Unwrap(v8::Handle<v8::Object>) [with T = node::crypto::SecureContext]: Assertion `handle->InternalFieldCount() > 0' failed. zsh: abort (core dumped) node PR-URL: https://github.com/nodejs/node/pull/24241 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'lib/_tls_common.js')
0 files changed, 0 insertions, 0 deletions