summaryrefslogtreecommitdiff
path: root/lib/_tls_common.js
diff options
context:
space:
mode:
authorBen Noordhuis <info@bnoordhuis.nl>2017-07-24 14:36:36 +0200
committerBen Noordhuis <info@bnoordhuis.nl>2017-07-27 17:36:50 +0200
commit06a684aab4422ca0cc455956d78eb76fee9ee076 (patch)
tree5970c3f685c218ff54c45ab99467bc27c2d00060 /lib/_tls_common.js
parent1b7372f2fb55f704b885e1097e2ec0381068c855 (diff)
downloadandroid-node-v8-06a684aab4422ca0cc455956d78eb76fee9ee076.tar.gz
android-node-v8-06a684aab4422ca0cc455956d78eb76fee9ee076.tar.bz2
android-node-v8-06a684aab4422ca0cc455956d78eb76fee9ee076.zip
tls: fix empty issuer/subject/infoAccess parsing
Also issuerCertificate but that did not fit on the status line. Fixes: https://github.com/nodejs/node/issues/11771 PR-URL: https://github.com/nodejs/node/pull/14473 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'lib/_tls_common.js')
-rw-r--r--lib/_tls_common.js8
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/_tls_common.js b/lib/_tls_common.js
index afcc5bc5fa..36b2ebdad6 100644
--- a/lib/_tls_common.js
+++ b/lib/_tls_common.js
@@ -169,12 +169,12 @@ exports.translatePeerCertificate = function translatePeerCertificate(c) {
if (!c)
return null;
- if (c.issuer) c.issuer = tls.parseCertString(c.issuer);
- if (c.issuerCertificate && c.issuerCertificate !== c) {
+ if (c.issuer != null) c.issuer = tls.parseCertString(c.issuer);
+ if (c.issuerCertificate != null && c.issuerCertificate !== c) {
c.issuerCertificate = translatePeerCertificate(c.issuerCertificate);
}
- if (c.subject) c.subject = tls.parseCertString(c.subject);
- if (c.infoAccess) {
+ if (c.subject != null) c.subject = tls.parseCertString(c.subject);
+ if (c.infoAccess != null) {
var info = c.infoAccess;
c.infoAccess = {};