diff options
| author | Brian White <mscdex@mscdex.net> | 2018-05-01 00:29:16 -0400 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-05-07 09:44:26 +0200 |
| commit | 8f6ab9f799925da836b6c106ed9a8b3d95a2935f (patch) | |
| tree | 616992afab96f547420ff2bb2eb325861ed84d8a /lib/_stream_writable.js | |
| parent | 5efbe4c1e8f9baf4251c40c52ca9452d8f7416ce (diff) | |
| download | android-node-v8-8f6ab9f799925da836b6c106ed9a8b3d95a2935f.tar.gz android-node-v8-8f6ab9f799925da836b6c106ed9a8b3d95a2935f.tar.bz2 android-node-v8-8f6ab9f799925da836b6c106ed9a8b3d95a2935f.zip | |
Revert "stream: prevent 'end' to be emitted after 'error'"
This reverts commit 08577906569a4c2de70ad2a861e2f8456cd8fcdd.
PR-URL: https://github.com/nodejs/node/pull/20449
Fixes: https://github.com/nodejs/node/issues/20334
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'lib/_stream_writable.js')
| -rw-r--r-- | lib/_stream_writable.js | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js index 0891f85526..d21daf0541 100644 --- a/lib/_stream_writable.js +++ b/lib/_stream_writable.js @@ -424,22 +424,12 @@ function onwriteError(stream, state, sync, er, cb) { // this can emit finish, and it will always happen // after error process.nextTick(finishMaybe, stream, state); - - // needed for duplex, fixes https://github.com/nodejs/node/issues/6083 - if (stream._readableState) { - stream._readableState.errorEmitted = true; - } stream._writableState.errorEmitted = true; stream.emit('error', er); } else { // the caller expect this to happen before if // it is async cb(er); - - // needed for duplex, fixes https://github.com/nodejs/node/issues/6083 - if (stream._readableState) { - stream._readableState.errorEmitted = true; - } stream._writableState.errorEmitted = true; stream.emit('error', er); // this can emit finish, but finish must |