diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-01-08 01:14:06 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-01 10:53:26 +0100 |
| commit | 7c4b09b24bbe7d6a8cbad256f47b30a101a909ea (patch) | |
| tree | 1aef41b1fd1cc0aad300b178e0a19e6da29615c8 /lib/_http_server.js | |
| parent | 1b6cb947611de5865641d1a6780ee6930a4e1d69 (diff) | |
| download | android-node-v8-7c4b09b24bbe7d6a8cbad256f47b30a101a909ea.tar.gz android-node-v8-7c4b09b24bbe7d6a8cbad256f47b30a101a909ea.tar.bz2 android-node-v8-7c4b09b24bbe7d6a8cbad256f47b30a101a909ea.zip | |
src: refactor stream callbacks and ownership
Instead of setting individual callbacks on streams and tracking
stream ownership through a boolean `consume_` flag, always have
one specific listener object in charge of a stream, and call
methods on that object rather than generic C-style callbacks.
PR-URL: https://github.com/nodejs/node/pull/18334
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'lib/_http_server.js')
| -rw-r--r-- | lib/_http_server.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/_http_server.js b/lib/_http_server.js index c60119822a..496ebf285c 100644 --- a/lib/_http_server.js +++ b/lib/_http_server.js @@ -666,7 +666,7 @@ function onSocketPause() { function unconsume(parser, socket) { if (socket._handle) { if (parser._consumed) - parser.unconsume(socket._handle._externalStream); + parser.unconsume(); parser._consumed = false; socket.removeListener('pause', onSocketPause); socket.removeListener('resume', onSocketResume); |