http: misc optimizations and style fixes

PR-URL: https://github.com/nodejs/node/pull/10558
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

1 files changed, 5 insertions, 8 deletions

diff --git a/lib/_http_server.js b/lib/_http_server.js
index d473fd3281..be55784e7e 100644
--- a/lib/_http_server.js
+++ b/lib/_http_server.js
@@ -170,8 +170,8 @@ function writeHead(statusCode, reason, obj) {
     this.statusMessage = reason;
   } else {
     // writeHead(statusCode[, headers])
-    this.statusMessage =
-        this.statusMessage || STATUS_CODES[statusCode] || 'unknown';
+    if (!this.statusMessage)
+      this.statusMessage = STATUS_CODES[statusCode] || 'unknown';
     obj = reason;
   }
   this.statusCode = statusCode;
@@ -514,9 +514,8 @@ function parserOnIncoming(server, socket, state, req, keepAlive) {
   // so that we don't become overwhelmed by a flood of
   // pipelined requests that may never be resolved.
   if (!socket._paused) {
-    var needPause = socket._writableState.needDrain ||
-        state.outgoingData >= socket._writableState.highWaterMark;
-    if (needPause) {
+    var ws = socket._writableState;
+    if (ws.needDrain || state.outgoingData >= ws.highWaterMark) {
       socket._paused = true;
       // We also need to pause the parser, but don't do that until after
       // the call to execute, because we may still be processing the last
@@ -542,9 +541,7 @@ function parserOnIncoming(server, socket, state, req, keepAlive) {
 
   // When we're finished writing the response, check if this is the last
   // response, if so destroy the socket.
-  var finish =
-    resOnFinish.bind(undefined, req, res, socket, state);
-  res.on('finish', finish);
+  res.on('finish', resOnFinish.bind(undefined, req, res, socket, state));
 
   if (req.headers.expect !== undefined &&
       (req.httpVersionMajor === 1 && req.httpVersionMinor === 1)) {