http: change DEP0066 to a runtime deprecation

Change doc-only deprecation for _headers and _headerNames accessors to a
runtime deprecation.

PR-URL: https://github.com/nodejs/node/pull/24167
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

1 files changed, 8 insertions, 8 deletions

diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
index 04a36d2be2..3bedce9d51 100644
--- a/lib/_http_outgoing.js
+++ b/lib/_http_outgoing.js
@@ -110,10 +110,10 @@ util.inherits(OutgoingMessage, Stream);
 
 
 Object.defineProperty(OutgoingMessage.prototype, '_headers', {
-  get: function() {
+  get: util.deprecate(function() {
     return this.getHeaders();
-  },
-  set: function(val) {
+  }, 'OutgoingMessage.prototype._headers is deprecated', 'DEP0066'),
+  set: util.deprecate(function(val) {
     if (val == null) {
       this[outHeadersKey] = null;
     } else if (typeof val === 'object') {
@@ -124,11 +124,11 @@ Object.defineProperty(OutgoingMessage.prototype, '_headers', {
         headers[name.toLowerCase()] = [name, val[name]];
       }
     }
-  }
+  }, 'OutgoingMessage.prototype._headers is deprecated', 'DEP0066')
 });
 
 Object.defineProperty(OutgoingMessage.prototype, '_headerNames', {
-  get: function() {
+  get: util.deprecate(function() {
     const headers = this[outHeadersKey];
     if (headers !== null) {
       const out = Object.create(null);
@@ -141,8 +141,8 @@ Object.defineProperty(OutgoingMessage.prototype, '_headerNames', {
       return out;
     }
     return null;
-  },
-  set: function(val) {
+  }, 'OutgoingMessage.prototype._headerNames is deprecated', 'DEP0066'),
+  set: util.deprecate(function(val) {
     if (typeof val === 'object' && val !== null) {
       const headers = this[outHeadersKey];
       if (!headers)
@@ -154,7 +154,7 @@ Object.defineProperty(OutgoingMessage.prototype, '_headerNames', {
           header[0] = val[keys[i]];
       }
     }
-  }
+  }, 'OutgoingMessage.prototype._headerNames is deprecated', 'DEP0066')
 });