diff options
author | James M Snell <jasnell@gmail.com> | 2018-08-23 10:16:00 -0700 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-09-19 11:07:01 +0200 |
commit | 9d71e6a6071134789a30471302d9735250dea96c (patch) | |
tree | 67a21cf09e3f5e3dd152ba22717ace87860e2f23 /lib/_http_client.js | |
parent | 6e746f1a55e5d94f1a8330d3436a64ed8d6f639b (diff) | |
download | android-node-v8-9d71e6a6071134789a30471302d9735250dea96c.tar.gz android-node-v8-9d71e6a6071134789a30471302d9735250dea96c.tar.bz2 android-node-v8-9d71e6a6071134789a30471302d9735250dea96c.zip |
src: deprecate global COUNTER_* and remove perfctr
To support Performance Counters on Windows, a number of
global `COUNTER_` methods were added that are undocumented
and really only intended to be used internally by Node.js.
Unfortunately, the perfctr support apparently hasn't even
worked for quite a while and no one has even complained.
This removes the perfctr support and replaces the global
functions with deprecated non-ops for now, with the intent
of removing those outright in the next major release cycle.
PR-URL: https://github.com/nodejs/node/pull/22485
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Diffstat (limited to 'lib/_http_client.js')
-rw-r--r-- | lib/_http_client.js | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/_http_client.js b/lib/_http_client.js index 372ac0f953..cbc7774489 100644 --- a/lib/_http_client.js +++ b/lib/_http_client.js @@ -285,7 +285,6 @@ util.inherits(ClientRequest, OutgoingMessage); ClientRequest.prototype._finish = function _finish() { DTRACE_HTTP_CLIENT_REQUEST(this, this.connection); - COUNTER_HTTP_CLIENT_REQUEST(); OutgoingMessage.prototype._finish.call(this); }; @@ -554,7 +553,6 @@ function parserOnIncomingClient(res, shouldKeepAlive) { } DTRACE_HTTP_CLIENT_RESPONSE(socket, req); - COUNTER_HTTP_CLIENT_RESPONSE(); req.res = res; res.req = req; |