diff options
| author | Sam Roberts <vieuxtech@gmail.com> | 2019-06-02 18:11:48 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-06-17 11:58:26 +0200 |
| commit | 574985cec8d96ee33be957f247941ad2c9e522bf (patch) | |
| tree | 76f362d7bc75173ed329694ea61b750512ef39fd /lib/_http_agent.js | |
| parent | 7cb89819b5681b72c38ea1957c681243329b93fd (diff) | |
| download | android-node-v8-574985cec8d96ee33be957f247941ad2c9e522bf.tar.gz android-node-v8-574985cec8d96ee33be957f247941ad2c9e522bf.tar.bz2 android-node-v8-574985cec8d96ee33be957f247941ad2c9e522bf.zip | |
https: do not automatically use invalid servername
Stop automatically setting servername in https.request() if the target
host is specified with an IP address. Doing so is invalid, and triggers
a deprecation warning. It is still possible to send an IP address as a
servername if its required, but it needs to be explicity configured, it
won't happen automatically.
PR-URL: https://github.com/nodejs/node/pull/28209
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'lib/_http_agent.js')
| -rw-r--r-- | lib/_http_agent.js | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/_http_agent.js b/lib/_http_agent.js index 12f8529c38..e1cfa6d7fc 100644 --- a/lib/_http_agent.js +++ b/lib/_http_agent.js @@ -256,6 +256,9 @@ function calculateServerName(options, req) { servername = hostHeader.split(':', 1)[0]; } } + // Don't implicitly set invalid (IP) servernames. + if (net.isIP(servername)) + servername = ''; return servername; } |