diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-18 03:47:55 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-23 02:55:55 +0100 |
| commit | 3fe1e80896d69b2125e3a264d0707fdbc6f37740 (patch) | |
| tree | 8e909c53a2cdf52650504f21467e9961d2aec6ef /lib/.eslintrc.yaml | |
| parent | bfbce289c33b12aafb82bd5b45bcb4412850b28f (diff) | |
| download | android-node-v8-3fe1e80896d69b2125e3a264d0707fdbc6f37740.tar.gz android-node-v8-3fe1e80896d69b2125e3a264d0707fdbc6f37740.tar.bz2 android-node-v8-3fe1e80896d69b2125e3a264d0707fdbc6f37740.zip | |
lib: validate Error.captureStackTrace() calls
This adds a custom eslint rule to verify that
`Error.captureStackTrace()` is only called if necessary. In most
cases the helper function should be used instead.
PR-URL: https://github.com/nodejs/node/pull/26738
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'lib/.eslintrc.yaml')
| -rw-r--r-- | lib/.eslintrc.yaml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml index fcb9ea7feb..3b041d5db4 100644 --- a/lib/.eslintrc.yaml +++ b/lib/.eslintrc.yaml @@ -15,6 +15,8 @@ rules: # Config specific to lib - selector: "NewExpression[callee.name=/Error$/]:not([callee.name=/^(AssertionError|NghttpError)$/])" message: "Use an error exported by the internal/errors module." + - selector: "CallExpression[callee.object.name='Error'][callee.property.name='captureStackTrace']" + message: "Please use `require('internal/errors').hideStackFrames()` instead." # Custom rules in tools/eslint-rules node-core/require-globals: error node-core/no-let-in-for-declaration: error |