diff options
| author | Christopher Hiller <boneskull@boneskull.com> | 2019-06-12 07:51:15 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-06-15 20:53:07 -0700 |
| commit | 7561a38ccd7cc6b543a81a62fdbd455f600f684e (patch) | |
| tree | ca1cadfc5c72b4288183d9f2dea3ef8cadf88c35 /doc | |
| parent | 9939762322de29224fcbc2f08c4a6a4bc08d6ccd (diff) | |
| download | android-node-v8-7561a38ccd7cc6b543a81a62fdbd455f600f684e.tar.gz android-node-v8-7561a38ccd7cc6b543a81a62fdbd455f600f684e.tar.bz2 android-node-v8-7561a38ccd7cc6b543a81a62fdbd455f600f684e.zip | |
report: add cpu info to report output
The report shows CPU consumption %, but without the number of CPU cores,
a consumer cannot tell if the percent (given across all cores) is
actually problematic. E.g., 100% on one CPU is a problem, but 100% on
four CPUs is not necessarily.
This change adds CPU information (similar to `os.cpus()`) to the report
output. Extra info besides the count is also provided as to avoid future
breaking changes in the eventuality that someone needs it; changing the
datatype of `header.cpus` would be breaking.
PR-URL: https://github.com/nodejs/node/pull/28188
Refs: https://github.com/nodejs/diagnostics/issues/307
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/api/report.md | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/doc/api/report.md b/doc/api/report.md index 40e3050ee4..9d773f25ee 100644 --- a/doc/api/report.md +++ b/doc/api/report.md @@ -62,6 +62,26 @@ is provided below for reference. "osRelease": "3.10.0-862.el7.x86_64", "osVersion": "#1 SMP Wed Mar 21 18:14:51 EDT 2018", "osMachine": "x86_64", + "osCpus": [ + { + "model": "Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz", + "speed": 2700, + "user": 88902660, + "nice": 0, + "sys": 50902570, + "idle": 241732220, + "irq": 0 + }, + { + "model": "Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz", + "speed": 2700, + "user": 88902660, + "nice": 0, + "sys": 50902570, + "idle": 241732220, + "irq": 0 + } + ], "host": "test_machine" }, "javascriptStack": { |