diff options
| author | Alba Mendez <me@alba.sh> | 2019-05-26 13:12:41 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-05-28 10:59:53 -0700 |
| commit | 42d80113bbd4ad5d790e061ea7568a04f0e900c6 (patch) | |
| tree | 7de0fb7c9e34795b7b277a5f516eec54e9bd5e06 /doc | |
| parent | 3b50bded08c2cbcc652b79346121b4e39de231fc (diff) | |
| download | android-node-v8-42d80113bbd4ad5d790e061ea7568a04f0e900c6.tar.gz android-node-v8-42d80113bbd4ad5d790e061ea7568a04f0e900c6.tar.bz2 android-node-v8-42d80113bbd4ad5d790e061ea7568a04f0e900c6.zip | |
doc,test: clarify that Http2Stream is destroyed after data is read
Correct docs to clarify that behaviour,
and fix a race condition in test-http2-large-write-destroy.js.
Fixes: https://github.com/nodejs/node/issues/27863
PR-URL: https://github.com/nodejs/node/pull/27891
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/api/http2.md | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/doc/api/http2.md b/doc/api/http2.md index 8176b83e9f..f5dea9640a 100644 --- a/doc/api/http2.md +++ b/doc/api/http2.md @@ -907,8 +907,9 @@ the value is `undefined`, the stream is not yet ready for use. All [`Http2Stream`][] instances are destroyed either when: -* An `RST_STREAM` frame for the stream is received by the connected peer. -* The `http2stream.close()` method is called. +* An `RST_STREAM` frame for the stream is received by the connected peer, + and pending data has been read. +* The `http2stream.close()` method is called, and pending data has been read. * The `http2stream.destroy()` or `http2session.destroy()` methods are called. When an `Http2Stream` instance is destroyed, an attempt will be made to send an |