summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2018-02-23 16:29:45 -0800
committerLeko <leko.noor@gmail.com>2018-02-26 22:01:15 +0900
commit1460b31bd3a9699bed9b715f0e8c1edb4fd0aa44 (patch)
tree4b07d4f938464c21549164f1157b09b0e3577448 /doc
parent65ca369c070cefcaf6300a234de6448f3015e8e8 (diff)
downloadandroid-node-v8-1460b31bd3a9699bed9b715f0e8c1edb4fd0aa44.tar.gz
android-node-v8-1460b31bd3a9699bed9b715f0e8c1edb4fd0aa44.tar.bz2
android-node-v8-1460b31bd3a9699bed9b715f0e8c1edb4fd0aa44.zip
doc: update 2fa information in onboarding.md
Because it is no longer possible to add someone to the nodejs GitHub organization if they do not have two-factor authentication enabled, update the text of the onboarding documentatino to reflect this. PR-URL: https://github.com/nodejs/node/pull/18968 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Diffstat (limited to 'doc')
-rw-r--r--doc/onboarding.md11
1 files changed, 4 insertions, 7 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md
index 352a181f4d..a85e493d3c 100644
--- a/doc/onboarding.md
+++ b/doc/onboarding.md
@@ -5,10 +5,10 @@ onboarding session.
## One week before the onboarding session
-* Confirm that the new Collaborator is using two-factor authentication on their
- GitHub account. Unless two-factor authentication is enabled, do not give an
- account elevated privileges such as the ability to land code in the main
- repository or to start continuous integration (CI) jobs.
+* If the new Collaborator is not yet a member of the nodejs GitHub organization,
+ confirm that they are using two-factor authentication. It will not be possible
+ to add them to the organization if they are not using two-factor
+ authentication.
* Announce the accepted nomination in a TSC meeting and in the TSC
mailing list.
@@ -16,9 +16,6 @@ onboarding session.
* Prior to the onboarding session, add the new Collaborator to
[the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators).
- Note that this is the step that gives the account elevated privileges, so do
- not perform this step (or any subsequent steps) unless two-factor
- authentication is enabled on the new Collaborator's GitHub account.
## Onboarding session