diff options
| author | Rich Trott <rtrott@gmail.com> | 2016-08-10 15:22:01 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2016-08-12 14:02:28 -0700 |
| commit | fa1476cb5017568c006199e98cefe865bcaf0f9e (patch) | |
| tree | 27a851ca8bcada2a35f70e45a1568d3233ae0ab5 /doc/onboarding.md | |
| parent | b9487449e151b02ff8cb1f3b4a0311e9eb0878e2 (diff) | |
| download | android-node-v8-fa1476cb5017568c006199e98cefe865bcaf0f9e.tar.gz android-node-v8-fa1476cb5017568c006199e98cefe865bcaf0f9e.tar.bz2 android-node-v8-fa1476cb5017568c006199e98cefe865bcaf0f9e.zip | |
doc: add POST_STATUS_TO_PR info to onboarding doc
`POST_STATUS_TO_PR` previously did not work.
Now it works.
Update the onboarding documentation accordingly.
PR-URL: https://github.com/nodejs/node/pull/8059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index f75a263741..94e475cdb2 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -110,8 +110,7 @@ Ensure everyone is added to https://github.com/orgs/nodejs/teams/collaborators * To start CI testing from this screen, you need to fill in two elements on the form: * The `CERTIFY_SAFE` box should be checked. By checking it, you are indicating that you have reviewed the code you are about to test and you are confident that it does not contain any malicious code. (We don't want people hijacking our CI hosts to attack other hosts on the internet, for example!) * The `PR_ID` box should be filled in with the number identifying the pull request containing the code you wish to test. For example, if the URL for the pull request is https://github.com/nodejs/node/issues/7006, then put `7006` in the `PR_ID`. - * The remaining elements on the form are typically unchanged. - * There is a checkbox for `POST_STATUS_TO_PR`. At the time of this writing, that checkbox does not do anything, but that is likely to change soon. Until that functionality is working, you will want to go back to the PR you are testing and paste `CI: <URL-of-the-CI-test-run>` into a comment on the pull request. + * The remaining elements on the form are typically unchanged with the exception of `POST_STATUS_TO_PR`. Check that if you want a CI status indicator to be automatically inserted into the PR. ### process for getting code in: |