diff options
| author | jessicaquynh <jessica.quynh.tran@gmail.com> | 2016-10-11 21:37:29 -0400 |
|---|---|---|
| committer | Myles Borins <mborins@us.ibm.com> | 2016-10-13 21:23:36 -0400 |
| commit | c2984ce19a4c1f139bc75ff6b2348f7feb35b3a9 (patch) | |
| tree | b90daec53c8a1575d1f8999a3c462e17914e57d2 /doc/onboarding.md | |
| parent | ec7f3a16749cd84679dc2de091eded17c6229827 (diff) | |
| download | android-node-v8-c2984ce19a4c1f139bc75ff6b2348f7feb35b3a9.tar.gz android-node-v8-c2984ce19a4c1f139bc75ff6b2348f7feb35b3a9.tar.bz2 android-node-v8-c2984ce19a4c1f139bc75ff6b2348f7feb35b3a9.zip | |
doc: explain why GitHub merge button is not used
Adds documentation and explicit reasons on why
the GitHub web interface button is not used. This was
explained in the referenced issue by @TheAlphaNerd.
Fixes: https://github.com/nodejs/node/issues/8893
PR-URL: https://github.com/nodejs/node/pull/9044
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index e9d6a4bd24..e22c876893 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -164,8 +164,15 @@ onboarding session. ## Landing PRs: Details -* Please never use GitHub's green "Merge Pull Request" button. +* Please never use GitHub's green ["Merge Pull Request"](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-using-the-github-web-interface) button. * If you do, please force-push removing the merge. + * Reasons for not using the web interface button: + * The merge method will add an unnecessary merge commit. + * The rebase & merge method adds metadata to the commit title. + * The rebase method changes the author. + * The squash & merge method has been known to add metadata to the commit title. + * If more than one author has contributed to the PR, only the latest author will be considered during the squashing. + Update your `master` branch (or whichever branch you are landing on, almost always `master`) |