diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-12-13 15:36:42 +0100 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-12-13 08:40:45 -0800 |
| commit | afeb56adf0c106cc4535d0ee20da078478be7ca2 (patch) | |
| tree | 0eb1e9973d983474defdac94029c75c428e9e8ab /doc/onboarding.md | |
| parent | c992639fbdc61fa78dc407ac09f633b102c55925 (diff) | |
| download | android-node-v8-afeb56adf0c106cc4535d0ee20da078478be7ca2.tar.gz android-node-v8-afeb56adf0c106cc4535d0ee20da078478be7ca2.tar.bz2 android-node-v8-afeb56adf0c106cc4535d0ee20da078478be7ca2.zip | |
doc: fix author-ready conflict
The onboarding docs still contained an outdated description of the
`author-ready` label. Now it references the main description to
prevent any future conflicts.
PR-URL: https://github.com/nodejs/node/pull/25015
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index 133680a8cf..5938803e53 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -96,11 +96,7 @@ onboarding session. `semver-major` label * When adding a `semver-*` label, add a comment explaining why you're adding it. Do it right away so you don't forget! - * Please add the `author-ready` label for PRs where: - * the CI has been started (not necessarily finished), - * no outstanding review comments exist and - * at least two Collaborators approved the PR (one Collaborator approval is - enough if the pull request has been open for more than 7 days). + * Please add the [`author-ready`][] label for PRs, if applicable. * See [Who to CC in the issue tracker][who-to-cc]. * This will come more naturally over time @@ -245,6 +241,7 @@ needs to be pointed out separately during the onboarding. the [summit](https://github.com/nodejs/summit) repository for details. [Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md +[`author-ready`]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#author-ready-pull-requests [`core-validate-commit`]: https://github.com/nodejs/core-validate-commit [`git-node`]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md [`node-core-utils`]: https://github.com/nodejs/node-core-utils |